Skip to content

ci(ember): Only run pinned tests for ember on build, + add canary tests #6847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 18, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Jan 18, 2023

Now, the ember tests are run "normally" as part of the browser unit tests, plus with the canary tests we run it in all envs (which are the latest versions), potentially spotting breaking changes.

@mydea mydea added Package: ember Issues related to the Sentry Ember SDK Dev: CI labels Jan 18, 2023
@mydea mydea requested review from lforst, Lms24 and AbhiPrasad January 18, 2023 12:16
@mydea mydea self-assigned this Jan 18, 2023
They are run in the browser unit tests
@mydea mydea force-pushed the fn/ember-cache-build branch from 657c891 to 542cfcc Compare January 18, 2023 12:17
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.82 KB (+0.01% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 61.47 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.5 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 54.77 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.22 KB (0%)
@sentry/browser - Webpack (minified) 66.17 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.24 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.52 KB (+0.03% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.74 KB (+0.03% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.03 KB (+0.05% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 43.12 KB (-0.82% 🔽)
@sentry/replay - Webpack (gzipped + minified) 38.45 KB (-1% 🔽)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 60.37 KB (-0.58% 🔽)

@mydea mydea merged commit c06756c into master Jan 18, 2023
@mydea mydea deleted the fn/ember-cache-build branch January 18, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dev: CI Package: ember Issues related to the Sentry Ember SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants