Skip to content

fix(core): Fix replay client report data category (??) #6891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2023
Merged

fix(core): Fix replay client report data category (??) #6891

merged 1 commit into from
Jan 20, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Jan 20, 2023

Not 100% sure if I'm missing something, but would this work?

ref #6889

@mydea mydea self-assigned this Jan 20, 2023
@mydea mydea mentioned this pull request Jan 20, 2023
Closed
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.83 KB (+0.05% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 61.48 KB (+0.03% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.5 KB (+0.04% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 54.79 KB (+0.03% 🔺)
@sentry/browser - Webpack (gzipped + minified) 20.22 KB (+0.05% 🔺)
@sentry/browser - Webpack (minified) 66.19 KB (+0.03% 🔺)
@sentry/react - Webpack (gzipped + minified) 20.25 KB (+0.04% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.48 KB (+0.02% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.76 KB (+0.05% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.04 KB (+0.03% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 43.26 KB (0%)
@sentry/replay - Webpack (gzipped + minified) 38.04 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 60.52 KB (+0.02% 🔺)

Lms24
Lms24 approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleaner, smaller and yes I think this should work. Let's go with this approach - thanks for proposing it!

@mydea mydea marked this pull request as ready for review January 20, 2023 14:35
@mydea mydea merged commit 8998fde into master Jan 20, 2023
@mydea mydea deleted the fn/replay-data-category branch January 20, 2023 14:36
@mydea
Copy link
Member Author

mydea commented Jan 20, 2023

👍 great find re: client report categories!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mydea @Lms24