Skip to content

ref(replay): Extract some more handlers out into functional style #6893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Jan 20, 2023

Extract some remaining handler stuff out into a functional style.
Also extract the global listener stuff (=things that cannot be reverted) out into a dedicated funtion.

@mydea mydea added the Package: replay Issues related to the Sentry Replay SDK label Jan 20, 2023
@mydea mydea requested review from billyvg and Lms24 January 20, 2023 14:39
@mydea mydea self-assigned this Jan 20, 2023
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.83 KB (+0.05% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 61.48 KB (+0.03% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.5 KB (+0.04% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 54.79 KB (+0.03% 🔺)
@sentry/browser - Webpack (gzipped + minified) 20.22 KB (+0.05% 🔺)
@sentry/browser - Webpack (minified) 66.19 KB (+0.03% 🔺)
@sentry/react - Webpack (gzipped + minified) 20.25 KB (+0.04% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.48 KB (+0.02% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.75 KB (+0.05% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.03 KB (+0.03% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 43.2 KB (-0.14% 🔽)
@sentry/replay - Webpack (gzipped + minified) 37.93 KB (-0.3% 🔽)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 60.55 KB (+0.06% 🔺)

@mydea mydea merged commit bee8d52 into master Jan 23, 2023
@mydea mydea deleted the fn/replay-functional branch January 23, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: replay Issues related to the Sentry Replay SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants