fix(replay): Handle compression worker errors more gracefully #6936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
billyvg
approved these changes
Jan 26, 2023
packages/replay/src/replay.ts
Outdated
| @@ -323,9 +330,18 @@ export class ReplayContainer implements ReplayContainerInterface { | |||
| * from calling both `flush` and `_debouncedFlush`. Otherwise, there could be | |||
| * cases of mulitple flushes happening closely together. | |||
| */ | |||
| public flushImmediate(): Promise<void> { | |||
| public async flushImmediate(waitForCompression?: boolean): Promise<void> { | |||
There was a problem hiding this comment.
Hmm, I guess we could also remove this option and just always use this behavior 🤔 WDYT?
There was a problem hiding this comment.
I actually moved this into the worker proxy itself, which will now always wait for this when calling finish().
mydea
force-pushed
the
fn/replay-eventBuffer
branch
from
a6977c8 to
84a73d6
Compare
|
@billyvg added a try-catch around the worker creation! |
mydea
force-pushed
the
fn/replay-eventBuffer
branch
from
5d7b5f7 to
a6f11c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially extracted from #6924
This PR improves the event buffer to handle compression worker errors more gracefully.