Skip to content

chore(wasm): Upgrade puppeteer to v18 #7048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 3, 2023

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Feb 2, 2023

This has been bothering me because yarn install on an M1 fails due to puppeteer.

This has been bothering me because `yarn install` on an M1 fails due to puppeteer.
@billyvg billyvg changed the title chore(wasm): Upgrade puppeteer to latest chore(wasm): Upgrade puppeteer to v18 Feb 3, 2023
@billyvg
Copy link
Member Author

billyvg commented Feb 3, 2023

v19 is not compatible with our version of typescript

@billyvg billyvg marked this pull request as ready for review February 3, 2023 00:46
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, puppeteer on M1 is a pain :(

Eventually, we want to get rid of it entirely (#6054). WASM tests are the last place where it's used. In the meantime let's upgrade if this solves the issue :)

@billyvg billyvg merged commit 9a22389 into develop Feb 3, 2023
@billyvg billyvg deleted the chore-wasm-upgrade-puppeteer-questionmark branch February 3, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants