-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
meta: Update Changelog for 7.37.2 #7158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue found in #7020 where `unblock` was not working for SVGs. This was due to our default media selectors including svg child elements. rrweb will handle blocking these as needed when the parent SVG is blocked.
[Gitflow] Merge master into develop
Upgrades rrweb library which will includes: - feat: Add `maskAllText` option - feat: With maskAllText, mask the attributes: placeholder, title, `aria-label` - feat: fix masking on `textarea`
test(replay): Test against full and errors+replay CDN bundles
We're gonna bump rrweb again - draft until ready |
billyvg
reviewed
Feb 13, 2023
CHANGELOG.md
Outdated
@@ -4,6 +4,13 @@ | |||
|
|||
- "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott | |||
|
|||
## 7.37.2 | |||
|
|||
This release includes [changes and fixes](https://github.com/getsentry/rrweb/releases/tag/1.102.0) around text masking in Replay's `rrweb` dependency. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be helpful to just embed rrweb changelog in here?
Suggested change
This release includes [changes and fixes](https://github.com/getsentry/rrweb/releases/tag/1.102.0) around text masking in Replay's `rrweb` dependency. | |
This release includes [changes and fixes](https://github.com/getsentry/rrweb/releases/tag/1.102.0) around text masking in Replay's `rrweb` dependency: | |
- feat: Add `maskAllText` option | |
- feat: With maskAllText, mask the attributes: placeholder, title, `aria-label` | |
- feat: fix masking on `textarea` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, done: f811483
9059209
to
f811483
Compare
size-limit report 📦
|
billyvg
approved these changes
Feb 13, 2023
f811483
to
53046d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting on 👍 from @billyvg