feat(replay): Change LCP calculation #7187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes up calculating LCP timing based on `web-vitals`. Previously we were using the `duration` field on the PerformanceEntry, but it was always 0. Decided to change the `data.duration` field to `data.value` so that we do not break the frontend when trying to display this new field.
|
The frontend currently calculates its own duration using start replay timestamp and LCP end timestamp (which == start timestamp). So any following LCP entries (e.g. after a refresh) will be incorrect. |
size-limit report 📦
|
mydea
approved these changes
Feb 16, 2023
billyvg
added a commit
to getsentry/sentry
that referenced
this pull request
Feb 17, 2023
Due to 7.38.0 (getsentry/sentry-javascript#7187) LCP endtimestamp was being incorrectly recorded. The end timestamp is used in our UI to calculate duration at the moment, so LCP with high values are causing our calculated duration to be incorrect. Ignore LCP in the duration calculation as a temporary fix. Ideally we would get SDK timestamps correct so that we only have the event duration as the source of truth for duration.
billyvg
added a commit
to getsentry/sentry
that referenced
this pull request
Feb 17, 2023
Due to 7.38.0 (getsentry/sentry-javascript#7187) LCP endtimestamp was being incorrectly recorded. The end timestamp is used in our UI to calculate duration at the moment, so LCP with high values are causing our calculated duration to be incorrect. Ignore LCP in the duration calculation as a temporary fix. Ideally we would get SDK timestamps correct so that we only have the event duration as the source of truth for duration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes up calculating LCP timing based on
web-vitals. Previously we were using thedurationfield on the PerformanceEntry, but it was always 0.Decided to change the
data.durationfield todata.valueso that we do not break the frontend when trying to display this new field.