Skip to content

ci: Add timeout to integration tests job #7243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 22, 2023
Merged

ci: Add timeout to integration tests job #7243

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cea388a
ci: Add timeout to integration tests job
mydea Feb 21, 2023
ad7363e
extend nextjs timeout
mydea Feb 22, 2023
35d4865
extend playwright timeout
mydea Feb 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,7 @@ jobs:
job_node_unit_tests:
name: Node (${{ matrix.node }}) Unit Tests
needs: [job_get_metadata, job_build]
timeout-minutes: 30
timeout-minutes: 10
runs-on: ubuntu-20.04
strategy:
fail-fast: false
Expand Down Expand Up @@ -469,7 +469,7 @@ jobs:
name: Nextjs (Node ${{ matrix.node }}) Tests
needs: [job_get_metadata, job_build]
if: needs.job_get_metadata.outputs.changed_nextjs == 'true' || github.event_name != 'pull_request'
timeout-minutes: 30
timeout-minutes: 15
runs-on: ubuntu-20.04
strategy:
fail-fast: false
Expand Down Expand Up @@ -528,6 +528,7 @@ jobs:
needs: [job_get_metadata, job_build]
if: needs.job_get_metadata.outputs.changed_browser_integration == 'true' || github.event_name != 'pull_request'
runs-on: ubuntu-20.04
timeout-minutes: 10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm probably missing something but aren't we already pretty close to 10 minutes? Just wondering if this is maybe a little too tight, wdyt?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, you're right, it varies a lot (sometimes 5min, sometimes 9min, ...) - I'll bump it to 15min!

strategy:
fail-fast: false
matrix:
Expand Down