-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
test(replay): Fix flaky flush test #7268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
size-limit report 📦
|
I'm actually not sure if there isn't some sort of problem with our flushing implementation rather than with test flakiness. We set |
Hmm we're even getting outliers with delays >2s: https://github.com/getsentry/sentry-javascript/actions/runs/4254985922/jobs/7402098735#step:11:264 It might just be that the runners are so slow that this just keeps on happening despite the maxdelay we set 🤔 |
90d5f6b
to
c567ade
Compare
This PR fixes the flakiness of our replay event flushing test by slightly changing the test requirements/expectations:
Note: I tested that flakes were gone by running this test 75x per CI job for multiple times and didn't see this test failing anymore.
closes #7266