Skip to content

ref(replay): Use SESSION_IDLE_DURATION instead of VISIBILITY_CHANGE_TIMEOUT #7297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Feb 28, 2023

Extracted this out of #7253

This allows us to simplify this code a bit (currently we have code paths that handle these being separate etc).

@mydea mydea added the Package: replay Issues related to the Sentry Replay SDK label Feb 28, 2023
@mydea mydea requested review from billyvg and Lms24 February 28, 2023 10:35
@mydea mydea self-assigned this Feb 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2023

Replay SDK metrics 🚀

    Plain +Sentry +Replay
Revision Value Value Diff Ratio Value Diff Ratio
LCP This PR 67b0684 102.84 ms 141.56 ms +38.72 ms +37.65 % 187.59 ms +84.74 ms +82.40 %
Previous 4b95c04 74.67 ms 100.14 ms +25.47 ms +34.11 % 132.23 ms +57.56 ms +77.09 %
CLS This PR 67b0684 0.06 ms 0.06 ms -0.00 ms -0.69 % 0.06 ms -0.00 ms -0.56 %
Previous 4b95c04 0.06 ms 0.06 ms -0.00 ms -0.79 % 0.06 ms -0.00 ms -0.47 %
CPU This PR 67b0684 23.24 % 22.62 % -0.61 pp -2.63 % 30.62 % +7.38 pp +31.77 %
Previous 4b95c04 12.32 % 12.48 % +0.16 pp +1.28 % 20.27 % +7.94 pp +64.46 %
JS heap avg This PR 67b0684 1.88 MB 2.31 MB +422.96 kB +22.45 % 3.59 MB +1.7 MB +90.45 %
Previous 4b95c04 1.94 MB 1.99 MB +43.74 kB +2.25 % 2.86 MB +920.88 kB +47.38 %
JS heap max This PR 67b0684 2.29 MB 2.68 MB +383.72 kB +16.73 % 4.1 MB +1.81 MB +78.88 %
Previous 4b95c04 2.3 MB 2.55 MB +249.86 kB +10.85 % 3.35 MB +1.05 MB +45.58 %
netTx This PR 67b0684 0 B 0 B 0 B n/a 2.23 kB +2.23 kB n/a
Previous 4b95c04 0 B 0 B 0 B n/a 2.21 kB +2.21 kB n/a
netRx This PR 67b0684 0 B 0 B 0 B n/a 41 B +41 B n/a
Previous 4b95c04 0 B 0 B 0 B n/a 41 B +41 B n/a
netCount This PR 67b0684 0 0 0 n/a 1 +1 n/a
Previous 4b95c04 0 0 0 n/a 1 +1 n/a
netTime This PR 67b0684 0.00 ms 0.00 ms 0.00 ms n/a 85.52 ms +85.52 ms n/a
Previous 4b95c04 0.00 ms 0.00 ms 0.00 ms n/a 90.32 ms +90.32 ms n/a

Previous results on branch: develop

RevisionLCPCLSCPUJS heap avgJS heap maxnetTxnetRxnetCountnetTime
4b95c04+57.56 ms-0.00 ms+7.94 pp+920.88 kB+1.05 MB+2.21 kB+41 B+1+90.32 ms
e60cd02+56.25 ms-0.00 ms+6.32 pp+927.44 kB+1.06 MB+2.21 kB+41 B+1+117.55 ms
e25c067+48.34 ms+0.00 ms+5.59 pp+926.37 kB+1.05 MB+2.22 kB+41 B+1+65.23 ms
b1b249b+43.88 ms+0.00 ms+4.80 pp+937.99 kB+1.05 MB+2.22 kB+41 B+1+111.56 ms
12e34d4+28.57 ms+0.00 ms+5.77 pp+930.12 kB+1.04 MB+2.26 kB+41 B+1+109.67 ms
c46c56c+65.45 ms-0.00 ms+5.38 pp+930.26 kB+1.07 MB+2.21 kB+41 B+1+91.29 ms
7f4c4ec+56.64 ms-0.00 ms+5.57 pp+927.42 kB+1.06 MB+2.21 kB+41 B+1+110.83 ms
00d2360+55.18 ms+0.00 ms+2.23 pp+934.14 kB+1.05 MB+2.22 kB+41 B+1+71.65 ms

*) pp - percentage points - an absolute difference between two percentages.
Last updated: Tue, 28 Feb 2023 10:50:28 GMT

@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.11 KB (+0.01% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 62.49 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.74 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified) 55.5 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.48 KB (0%)
@sentry/browser - Webpack (minified) 66.94 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.51 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 48.05 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 27.04 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.29 KB (+0.01% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 42.86 KB (-0.01% 🔽)
@sentry/replay - Webpack (gzipped + minified) 36.93 KB (-0.03% 🔽)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 60.44 KB (-0.03% 🔽)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 53.99 KB (0%)

Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for separating this out!

@mydea mydea force-pushed the fn/replay-times-config branch 3 times, most recently from 269f70a to 21e6d5d Compare March 1, 2023 10:59
@mydea mydea force-pushed the fn/replay-times-config branch 2 times, most recently from 417b31b to f69efd9 Compare March 1, 2023 16:55
@mydea mydea merged commit 3977189 into develop Mar 1, 2023
@mydea mydea deleted the fn/replay-times-config branch March 1, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: replay Issues related to the Sentry Replay SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants