test: Run playwright tests in parallel #7334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
mydea
force-pushed
the
fn/playwright-parallel
branch
from
82a097e to
379f59e
Compare
Lms24
approved these changes
Mar 6, 2023
| // Run tests inside of a single file in parallel | ||
| fullyParallel: true, | ||
| // Use 3 workers on CI, else use defaults (based on available CPU cores) | ||
| workers: process.env.CI ? 5 : undefined, |
There was a problem hiding this comment.
No, it was 3 previously and I randomly set it to 5 to see if it still works as expected, and it did (and was slightly faster on CI). FYI without this on CI it defaults to just one worker, because CI has two cores, and the default heuristic is # of CPUS/2.
I can also leave it at 3 for CI (but I guess that is equally random 😅 )
There was a problem hiding this comment.
No 5 is totally fine, I was just wondering 😅
There was a problem hiding this comment.
I will adjust the comment to make it clear this is an arbitrary number! 😂
AbhiPrasad
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This:
workersconfig for playwright, making sure we use the default on local machines (which depends on available CPU cores), and bump it to 5 on CI to speed this up slightly