feat(tracing): Move common tracing code to core #7339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…try-javascript into feat/tracing-in-core
AbhiPrasad
requested review from
a team,
lforst and
Lms24
and removed request for
a team
size-limit report 📦
|
lforst
reviewed
Mar 6, 2023
Comment on lines
+14
to
+15
| import { DEFAULT_ENVIRONMENT } from '../constants'; | ||
| import type { Hub } from '../hub'; |
There was a problem hiding this comment.
l: Do we want to point these to the actual definitions instead of to index?
There was a problem hiding this comment.
Changed the imports to use ../hub - does this still apply?
Comment on lines
+3
to
+4
| import type { Hub } from '../hub'; | ||
| import { getCurrentHub } from '../hub'; |
| */ | ||
| export function _addTracingExtensions(): void { | ||
| export function addTracingExtensions(): void { |
There was a problem hiding this comment.
l: Can we mark this as deprecated out of caution. I think we wanna move to dependency injection rather than functions with side-effects.
There was a problem hiding this comment.
Will do this in a follow up PR since we should make the deprecations the final step after we've moved everything over.
lforst
approved these changes
Mar 6, 2023
Lms24
approved these changes
Mar 6, 2023
| @@ -0,0 +1,72 @@ | |||
| import { addTracingExtensions, getMainCarrier } from '@sentry/core'; | |||
There was a problem hiding this comment.
the content of this file will be moved entirely to Node in the future, right?
There was a problem hiding this comment.
Yes it will! For now it should be completely tree-shaken out.
krystofwoldrich
added a commit
to getsentry/sentry-react-native
that referenced
this pull request
Mar 14, 2023
krystofwoldrich
added a commit
to getsentry/sentry-react-native
that referenced
this pull request
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes #7166
Closes #7091
This PR:
core/src/tracing@sentry/corenow exports the same common types plus:addTracingExtensions- Required so that@sentry/tracingcan still add the extensions viaaddExtensionMethodsTRACING_DEFAULTS- This contains the timing defaults that are used across tracingaddExtensionMethodsin@sentry/tracingdue to_autoloadDatabaseIntegrations@sentry/tracingto ensure there are no breaking changes to public APIidletransaction.test.tsimports code from core soIdleTransactionSpanRecorderdoesn't need to be made publicThis PR does not:
Span,Transaction, etc from@sentry/corerather than@sentry/tracing