-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
test: Make E2E tests async & parallelizable #7466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
AbhiPrasad
approved these changes
Mar 15, 2023
Lms24
approved these changes
Mar 16, 2023
No idea why this is failing on CI at build of the E2E apps with e.g.:
if anybody has an idea, happy for pointers 😬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the E2E test run async in
child_process.spawn
vschild_process.spawnSync
), so we can parallelize them.This required rather extensive refactoring of the E2E code, as making one piece of it async requires making everything async.
For now, we run 2 jobs in parallel on CI, 5 locally. We can adjust this later.
Some notes:
process.env.PORT
with a (hopefully) unique port.tmp
dir now before we build it, as otherwise it cannot work when multiple versions are specified. This should be cleaned up after the test run.Closes #7439