Skip to content

chore(repo): Fix yarn clean(:all) scripts #7478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Mar 16, 2023

The top-level yarn clean(:all) commands didn't work for me for quite a while now. The normal clean command was flaky while the other one always error'd. My suspicion is that cleaning the NX cache and running commands on the individual packages seems to collide. Likewise, removing node_modules while using an npm package (rimraf) to clean things. Running the individual clean commands in series vs. in parallel seems to fix this for me.

@Lms24 Lms24 requested review from mydea and AbhiPrasad March 16, 2023 09:58
@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.4 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 63.3 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.98 KB (-0.01% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 56.21 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.65 KB (0%)
@sentry/browser - Webpack (minified) 67.44 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.68 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 52.12 KB (+0.07% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 33.66 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.01 KB (+0.04% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 43.17 KB (-0.01% 🔽)
@sentry/replay - Webpack (gzipped + minified) 37.19 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 61.31 KB (+0.01% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 54.38 KB (-0.01% 🔽)

@Lms24 Lms24 merged commit 7399b99 into develop Mar 16, 2023
@Lms24 Lms24 deleted the lms/fix-top-level-clean branch March 16, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants