Skip to content

feat(tracing): Do not create interactions if navigation or pageload transaction active #7614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 30, 2023

Conversation

0Calories
Copy link
Contributor

Fixes a slight annoyance where interaction transactions would still be created alongside a pageload or navigation transaction. Both transactions at this point would have the same spans, so there's no need to duplicate them.

This scenario occurs when clicking a link in an SPA, basically whenever browserHistory.push is being called to perform a soft navigation.

@0Calories 0Calories requested review from AbhiPrasad and a team March 24, 2023 22:11
@0Calories 0Calories self-assigned this Mar 24, 2023
@0Calories 0Calories requested review from mydea and removed request for a team March 24, 2023 22:11
@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.62 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 64.4 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.15 KB (-0.02% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 56.78 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 21.53 KB (0%)
@sentry/browser - Webpack (minified) 72 KB (0%)
@sentry/react - Webpack (gzipped + minified) 21.55 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 52.02 KB (+0.1% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 28.18 KB (+0.08% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.38 KB (+0.07% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 44.74 KB (-0.01% 🔽)
@sentry/replay - Webpack (gzipped + minified) 38.86 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 63.43 KB (+0.04% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 56.49 KB (-0.01% 🔽)

@0Calories 0Calories requested review from mydea and a team March 28, 2023 14:52
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can merge after lint is fixed!

@AbhiPrasad
Copy link
Member

Pushed up linting fix so we can merge for release today.

@AbhiPrasad AbhiPrasad changed the title feat(interactions): Do not create interactions if navigation or pageload transaction active feat(tracing): Do not create interactions if navigation or pageload transaction active Mar 30, 2023
@AbhiPrasad AbhiPrasad enabled auto-merge (squash) March 30, 2023 07:40
@AbhiPrasad AbhiPrasad merged commit d98ac5d into develop Mar 30, 2023
@AbhiPrasad AbhiPrasad deleted the fix/interactions-during-nav branch March 30, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants