-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
build(cdn): Move tracing CDN bundle generation to @sentry/browser
#7617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Now all (main) CDN bundle generation is in a single place.
size-limit report 📦
|
I also updated the bundle build to run this in parallel for es5 & es6, as it is becoming quite slow. |
@sentry/browser
@sentry/browser
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's important the bundles have unified exports, esp for the loader, so I think the bundle size increase is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Now all (standalone) CDN bundle generation is in a single place.
This allows us to streamline the build process a bit, as this is now all inside of browser.
It also means we can get rid of the (IMHO a bit confusing)
PW_TRACING_ONLY
flag for the browser integration tests. Now we just pass the bundle.Finally, integration tests that depend on tracing will now actually only run in a tracing-enabled CDN bundle, the same as we do this for replay. This does mean a bit more boilerplate in the tests, but actually makes it very explicit which CDN bundle supports what. Previously, we'd just use the tracing bundle even when running in non-tracing builds for these tests.