Skip to content

test(utils): Add test for global rate limit response with scope #7631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Mar 28, 2023

This PR just adds a small test to check if the SDK parses a rate limit response that has no category but a scope: 60::organization. This came up in Slack and in https://github.com/getsentry/ops/pull/6446#discussion_r1150245408.

@Lms24 Lms24 requested review from lforst and mydea March 28, 2023 09:59
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.56 KB (0%)
@sentry/browser - ES5 CDN Bundle (minified) 64.19 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.12 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified) 56.57 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 21.58 KB (0%)
@sentry/browser - Webpack (minified) 71.65 KB (0%)
@sentry/react - Webpack (gzipped + minified) 21.6 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 51.94 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 28.11 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.32 KB (0%)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 44.47 KB (+0.23% 🔺)
@sentry/replay - Webpack (gzipped + minified) 38.54 KB (+0.27% 🔺)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 63.09 KB (+0.16% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 56.18 KB (+0.17% 🔺)

@Lms24 Lms24 self-assigned this Mar 28, 2023
@Lms24 Lms24 merged commit d330c2f into develop Mar 28, 2023
@Lms24 Lms24 deleted the lms/test-global-rate-limit-with-scope branch March 28, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants