ref(node): Clean up Undici options #7646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 29, 2023
lforst
approved these changes
Mar 29, 2023
| * }); | ||
| * ``` | ||
| */ | ||
| tracePropagationTargets?: TracePropagationTargets; | ||
|
|
||
| // TODO (v8): Remove this in v8 | ||
| /** | ||
| * @deprecated Moved to constructor options of the `Http` integration. |
There was a problem hiding this comment.
Didn't we wanna remove this deprecation entirely?
There was a problem hiding this comment.
I decided against this for now because it feels weird having this work only for requests as a top level API - we can re-visit later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7624
This PR does a couple of things.
tracePropagationTargetsas a top level option in Node options.shouldCreateSpanForRequestinto an option in the Undici integration.After these changes get merged in we can add Undici by default to both next.js and sveltekit. We can then think about adding it by default to the Node SDK.