Skip to content

doc(sveltekit): Move SDK initialization to hooks and restructure setup in README #7661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 30, 2023

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Mar 30, 2023

Restructures SDK setup into client, server and build setup sections. Also moves init call from dedicated files to hooks.

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big fan of the change :shipit:

@Lms24 Lms24 marked this pull request as ready for review March 30, 2023 08:43
Lms24 added a commit that referenced this pull request Mar 30, 2023
…7663)

To make our Sentry SDK setup easier, we'll instruct users to init the SDK in the hooks files rather than in the dedicated sentry.client|server.config.js files (#7661). To support this change, this PR makes the injection of our `injectSentryInitPlugin` into the users' build config depend on the existence of said sentry config files. If they don't exist, there's no need to add the plugin or adjust the server config.
@Lms24 Lms24 merged commit 1eb271a into develop Mar 30, 2023
@Lms24 Lms24 deleted the lms/sveltekit-readme-hooks branch March 30, 2023 09:13
@Lms24 Lms24 self-assigned this Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants