Skip to content

test(loader): Add tests for new loader integration handling #7790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Apr 7, 2023

These are tests added for getsentry/sentry#47082

This should make sure that:

  • If you do not add replay/browser tracing integrations, we add them for you
  • If you add them, we do not overwrite them but use your own config
  • If you add any other integrations, they are added in addition to replay/browser tracing

I also make sure we check the loader & integration bundles for ES5.

@mydea mydea requested a review from AbhiPrasad April 7, 2023 13:42
@mydea mydea self-assigned this Apr 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.94 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 65.44 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.49 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified) 57.88 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 21.1 KB (0%)
@sentry/browser - Webpack (minified) 68.84 KB (0%)
@sentry/react - Webpack (gzipped + minified) 21.12 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 48.9 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 28.5 KB (0%)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.73 KB (0%)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 44.89 KB (0%)
@sentry/replay - Webpack (gzipped + minified) 38.85 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 63.78 KB (0%)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 56.82 KB (0%)

@mydea mydea force-pushed the fn/loader-update branch from 56462e3 to 386cd2b Compare April 11, 2023 07:02
@mydea mydea enabled auto-merge (squash) April 11, 2023 07:22
@mydea mydea merged commit 1ad518f into develop Apr 11, 2023
@mydea mydea deleted the fn/loader-update branch April 11, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants