fix: Do refresh buffered sessions #7931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billyvg
approved these changes
Apr 21, 2023
size-limit report 📦
|
mydea
force-pushed
the
fn/adjust-pr-buffer-session-refresh
branch
from
d9400c3 to
777d471
Compare
billyvg
pushed a commit
that referenced
this pull request
Apr 24, 2023
billyvg
pushed a commit
that referenced
this pull request
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjusts the PR to handle buffered sessions that expire.
Basically, a buffered session should be sampled normally unless it has been converted from a buffered -> session. Only when an error was captured and the session then expires, we do not want to start a new session.
This fixes #7768