Skip to content

fix(replay): Ensure we do not set replayId on dsc if replay is disabled #7939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Apr 24, 2023

I noticed that we are actually setting the replayId on the DSC even if the replay has stopped. IMHO this doesn't make a lot of sense, so I added this guard.

@mydea mydea added Type: Bug Package: replay Issues related to the Sentry Replay SDK labels Apr 24, 2023
@mydea mydea requested review from billyvg, JoshFerge and Lms24 April 24, 2023 06:59
@mydea mydea self-assigned this Apr 24, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 24, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 21.02 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 65.66 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.56 KB (-0.01% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 58.12 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 21.17 KB (0%)
@sentry/browser - Webpack (minified) 69.07 KB (0%)
@sentry/react - Webpack (gzipped + minified) 21.19 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 49.03 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 28.59 KB (0%)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.82 KB (-0.01% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 46.21 KB (+0.01% 🔺)
@sentry/replay - Webpack (gzipped + minified) 40.09 KB (+0.02% 🔺)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 65.08 KB (+0.01% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 58.05 KB (+0.01% 🔺)

@mydea mydea force-pushed the fn/add-replay-dsc-if-enabled branch from 3cdb13f to 9db877a Compare April 24, 2023 09:07
@mydea mydea merged commit 5a3c29d into develop Apr 24, 2023
@mydea mydea deleted the fn/add-replay-dsc-if-enabled branch April 24, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: replay Issues related to the Sentry Replay SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants