Skip to content

test(e2e): Avoid race condition with event proxy #7965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 26, 2023
Merged

test(e2e): Avoid race condition with event proxy #7965

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fc7e9cc
test(e2e): Add pnpm in missing places
Apr 26, 2023
a289d55
wth man
Apr 26, 2023
6ed8d16
pin pnpm version
Apr 26, 2023
2f1a547
race condition
Apr 26, 2023
53d0dcc
jeez
Apr 26, 2023
9d428c5
.
Apr 26, 2023
44c0bd3
help
Apr 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/e2e-tests/test-applications/create-next-app/playwright.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ const config: PlaywrightTestConfig = {

/* Run your local dev server before starting the tests */
webServer: {
command: testEnv === 'development' ? `yarn next dev -p ${port}` : `yarn next start -p ${port}`,
command: testEnv === 'development' ? `pnpm next dev -p ${port}` : `pnpm next start -p ${port}`,
port,
},
};
Expand Down
4 changes: 2 additions & 2 deletions packages/e2e-tests/test-applications/create-next-app/test-recipe.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@
"tests": [
{
"testName": "Playwright tests - Prod Mode",
"testCommand": "yarn test:prod"
"testCommand": "pnpm test:prod"
},
{
"testName": "Playwright tests - Dev Mode",
"testCommand": "yarn test:dev"
"testCommand": "pnpm test:dev"
}
]
}
4 changes: 2 additions & 2 deletions packages/e2e-tests/test-applications/nextjs-app-dir/playwright.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,11 @@ const config: PlaywrightTestConfig = {
/* Run your local dev server before starting the tests */
webServer: [
{
command: testEnv === 'development' ? `yarn next dev -p ${port}` : `yarn next start -p ${port}`,
command: testEnv === 'development' ? `pnpm next dev -p ${port}` : `pnpm next start -p ${port}`,
port,
},
{
command: 'yarn ts-node-script start-event-proxy.ts',
command: 'pnpm ts-node-script start-event-proxy.ts',
port: Number(process.env.BASE_PORT) + Number(process.env.PORT_MODULO) + Number(process.env.PORT_GAP),
},
],
Expand Down
6 changes: 3 additions & 3 deletions packages/e2e-tests/test-applications/nextjs-app-dir/test-recipe.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@
"$schema": "../../test-recipe-schema.json",
"testApplicationName": "nextjs-13-app-dir",
"buildCommand": "pnpm install && npx playwright install && pnpm build",
"buildAssertionCommand": "yarn ts-node --script-mode assert-build.ts",
"buildAssertionCommand": "pnpm ts-node --script-mode assert-build.ts",
"tests": [
{
"testName": "Prod Mode",
"testCommand": "yarn test:prod"
"testCommand": "pnpm test:prod"
},
{
"testName": "Dev Mode",
"testCommand": "yarn test:dev"
"testCommand": "pnpm test:dev"
}
],
"canaryVersions": [
Expand Down
4 changes: 2 additions & 2 deletions packages/e2e-tests/test-applications/node-express-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
"version": "1.0.0",
"private": true,
"scripts": {
"build": "yarn tsc",
"build": "tsc",
"start": "node dist/app.js",
"test": "yarn playwright test"
"test": "playwright test"
},
"dependencies": {
"@sentry/integrations": "*",
Expand Down
2 changes: 1 addition & 1 deletion packages/e2e-tests/test-applications/node-express-app/playwright.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ const config: PlaywrightTestConfig = {

/* Run your local dev server before starting the tests */
webServer: {
command: 'yarn start',
command: 'pnpm start',
port: Number(process.env.BASE_PORT) + Number(process.env.PORT_MODULO),
},
};
Expand Down
2 changes: 1 addition & 1 deletion packages/e2e-tests/test-applications/node-express-app/test-recipe.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"tests": [
{
"testName": "Test express server",
"testCommand": "yarn test",
"testCommand": "pnpm test",
"timeoutSeconds": 60
}
]
Expand Down
2 changes: 1 addition & 1 deletion ...s/e2e-tests/test-applications/standard-frontend-react-tracing-import/playwright.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ const config: PlaywrightTestConfig = {

/* Run your local dev server before starting the tests */
webServer: {
command: 'yarn start',
command: 'pnpm start',
port: Number(process.env.BASE_PORT) + Number(process.env.PORT_MODULO),
env: {
PORT: String(Number(process.env.BASE_PORT) + Number(process.env.PORT_MODULO)),
Expand Down
2 changes: 1 addition & 1 deletion packages/e2e-tests/test-applications/standard-frontend-react-tracing-import/test-recipe.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"tests": [
{
"testName": "Playwright tests",
"testCommand": "yarn test"
"testCommand": "pnpm test"
}
],
"canaryVersions": []
Expand Down
2 changes: 1 addition & 1 deletion packages/e2e-tests/test-applications/standard-frontend-react/playwright.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ const config: PlaywrightTestConfig = {

/* Run your local dev server before starting the tests */
webServer: {
command: 'yarn start',
command: 'pnpm start',
port: Number(process.env.BASE_PORT) + Number(process.env.PORT_MODULO),
env: {
PORT: String(Number(process.env.BASE_PORT) + Number(process.env.PORT_MODULO)),
Expand Down
2 changes: 1 addition & 1 deletion packages/e2e-tests/test-applications/standard-frontend-react/test-recipe.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"tests": [
{
"testName": "Playwright tests",
"testCommand": "yarn test"
"testCommand": "pnpm test"
}
],
"canaryVersions": [
Expand Down