test: Fix flaky replay DSC test #7973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also one test was actually incorrect.
mydea
commented
Apr 26, 2023
| @@ -74,12 +81,13 @@ sentryTest( | |||
| }); | |||
| }); | |||
|
|
|||
| const envHeader = await getFirstSentryEnvelopeRequest<EventEnvelopeHeaders>(page, url, envelopeHeaderRequestParser); | |||
There was a problem hiding this comment.
This actually does page.goto(url) under the hood, so we were reloading the page, re-initializing replay.
mydea
commented
Apr 26, 2023
| const replay = await getReplaySnapshot(page); | ||
|
|
||
| expect(replay.session?.id).toBeDefined(); |
There was a problem hiding this comment.
This was just incorrect, we expect this to be undefined now 😅
AbhiPrasad
approved these changes
Apr 26, 2023
billyvg
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also one test was actually incorrect.
Also extending browser integration test max. time a bit as I had a few times where we exceeded 15min, sadly.