Skip to content

feat(sveltekit): Convert sentryHandle to a factory function #7975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Apr 26, 2023

This PR converts the sentyHandle server-side request handler to a factory function instead of a plain handler. This will allow us more freedom down the line to permit customization by passing options to the handler.
More details in #7951

Unfortunately, this is a breaking change but we need to change this now while the SDK is not yet stable.

closes #7951

@Lms24 Lms24 added the Package: sveltekit Issues related to the Sentry SvelteKit SDK label Apr 26, 2023
@Lms24 Lms24 requested review from mydea and AbhiPrasad April 26, 2023 14:16
@Lms24 Lms24 self-assigned this Apr 26, 2023
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 21.03 KB (+0.01% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 65.66 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.56 KB (+0.01% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 58.12 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 21.17 KB (0%)
@sentry/browser - Webpack (minified) 69.07 KB (0%)
@sentry/react - Webpack (gzipped + minified) 21.19 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 49.03 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 28.59 KB (0%)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.82 KB (+0.01% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 46.81 KB (+0.54% 🔺)
@sentry/replay - Webpack (gzipped + minified) 40.59 KB (+0.57% 🔺)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 65.62 KB (+0.43% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 58.57 KB (+0.42% 🔺)

@Lms24 Lms24 merged commit 5f9b9ce into develop Apr 26, 2023
@Lms24 Lms24 deleted the lms/sveltekit-sentryHandle-factory-function branch April 26, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: sveltekit Issues related to the Sentry SvelteKit SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make SvelteKit sentryHandle request handler a factory function
2 participants