Skip to content

feat(replay): Keep min. 30s of data in buffer & worker mode #7992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mydea
Copy link
Member

@mydea mydea commented Apr 28, 2023

This re-implements #7025 with a new strategy.
It only keeps min. 30s when using the compression worker (without the worker, the same strategy as now is used, only that it will keep up to 30s max). This may be acceptable, I think? We could also try to implement this for the event array buffer as well, but the question is if we want to do that or say "good enough" this way.

Probably needs a bit more manual testing as well, but wanted to put this up so we can talk about it at least.

Closes #6908

@github-actions
Copy link
Contributor

github-actions bot commented Apr 28, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 21.02 KB (+0.01% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 65.62 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.55 KB (-0.01% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 58.08 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 21.16 KB (0%)
@sentry/browser - Webpack (minified) 69.03 KB (0%)
@sentry/react - Webpack (gzipped + minified) 21.18 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 49.09 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 28.64 KB (0%)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.87 KB (+0.01% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 46.95 KB (+0.19% 🔺)
@sentry/replay - Webpack (gzipped + minified) 40.79 KB (+0.31% 🔺)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 65.83 KB (+0.15% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 58.72 KB (+0.15% 🔺)

Base automatically changed from fn/replay-manually-clear-buffer to develop May 2, 2023 08:17
@mydea mydea force-pushed the fn/replay-eventBuffer-min-30s branch 3 times, most recently from 9cc9311 to 1dc4778 Compare May 2, 2023 13:13
@mydea mydea requested a review from billyvg May 2, 2023 13:22
@mydea mydea self-assigned this May 2, 2023
@mydea mydea force-pushed the fn/replay-eventBuffer-min-30s branch from 1dc4778 to 68d21c3 Compare May 3, 2023 14:27
@mydea mydea added Type: Feature Package: replay Issues related to the Sentry Replay SDK labels May 3, 2023
@github-actions
Copy link
Contributor

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@github-actions
Copy link
Contributor

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot removed the Stale label Aug 9, 2023
@billyvg billyvg removed their request for review August 9, 2023 20:01
@billyvg
Copy link
Member

billyvg commented Aug 9, 2023

We have higher priority bugs atm, so this is going to take a backseat while we address those. Whenever you pick this up again @mydea, can you update against develop? I'd like to run benchmarks to see how this affects memory usage.

@getsantry
Copy link

getsantry bot commented Oct 18, 2023

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Oct 18, 2023
@mydea mydea removed the Stale label Oct 18, 2023
@mydea
Copy link
Member Author

mydea commented Dec 19, 2023

Closing this for now, if we ever want to revisit this we can.

@mydea mydea closed this Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: replay Issues related to the Sentry Replay SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keep min. 30 seconds for replay in error mode
3 participants