Skip to content

fix(replay): Do not add replay_id to DSC while buffering #8020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2023
Merged

fix(replay): Do not add replay_id to DSC while buffering #8020

merged 1 commit into from
May 3, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented May 3, 2023

We only want to add the replay_id to the DSC when the session is in session mode, as while buffering the replay may not even be sent.

Closes #8013

@mydea mydea requested review from billyvg and Lms24 May 3, 2023 07:13
@mydea mydea self-assigned this May 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 21.02 KB (0%)
@sentry/browser - ES5 CDN Bundle (minified) 65.66 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.56 KB (-0.01% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 58.12 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 21.17 KB (0%)
@sentry/browser - Webpack (minified) 69.07 KB (0%)
@sentry/react - Webpack (gzipped + minified) 21.19 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 49.05 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 28.63 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.84 KB (-0.01% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 46.87 KB (+0.01% 🔺)
@sentry/replay - Webpack (gzipped + minified) 40.67 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 65.71 KB (0%)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 58.64 KB (0%)

@mydea mydea force-pushed the fn/replay-dsc branch from 0b43e40 to d74f629 Compare May 3, 2023 11:12
@mydea mydea merged commit cfc401e into develop May 3, 2023
@mydea mydea deleted the fn/replay-dsc branch May 3, 2023 12:45
billyvg pushed a commit that referenced this pull request May 5, 2023
@mydea @billyvg
fix(replay): Do not add replay_id to DSC while buffering (#8020)
1e80026
@bruno-garcia bruno-garcia mentioned this pull request May 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billyvg billyvg billyvg approved these changes

@Lms24 Lms24 Lms24 approved these changes

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add replay DSC only when replay is in session mode
3 participants
@mydea @billyvg @Lms24