fix(sveltekit): Avoid creating the Sentry Vite plugin in dev mode #8065
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To upload source maps in SvelteKit, we create a custom plugin building on top of the Sentry Vite plugin, which creates a Sentry hub to collect telemetry. The problem is that in the current version of the Sentry Vite plugin, the hub is set as the current hub (
makeMain
) as soon as the plugin is created, causing tags from the plugin to leak to the user's Sentry projects in errors and transactions.This will be fixed in the new major of the vite plugin but we should nevertheless avoid this for now. Hence, this PR fixes this leakage by simply not creating the plugin when we're in dev mode.