Skip to content

test(e2e): Add canary tests for react e2e tests #8068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2023

Conversation

AbhiPrasad
Copy link
Member

See: https://react.dev/community/versioning-policy

React is going to do more stuff in experimental/canary channels. Let's make sure the basics still work and build.

@AbhiPrasad AbhiPrasad requested a review from lforst May 8, 2023 13:19
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 21.02 KB (+0.01% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 65.62 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.55 KB (-0.01% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 58.08 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 21.16 KB (+0.01% 🔺)
@sentry/browser - Webpack (minified) 69.03 KB (0%)
@sentry/react - Webpack (gzipped + minified) 21.18 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 49.09 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 28.64 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.86 KB (0%)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 47.35 KB (+0.16% 🔺)
@sentry/replay - Webpack (gzipped + minified) 41.13 KB (+0.15% 🔺)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 66.3 KB (+0.12% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 59.18 KB (+0.13% 🔺)

@lforst
Copy link
Contributor

lforst commented May 8, 2023

Can you do one canary test run on this branch and link it when it works? Thanks!

@AbhiPrasad AbhiPrasad changed the title test(e2e): Add canary/experimental tests for react e2e tests test(e2e): Add canary tests for react e2e tests May 8, 2023
@AbhiPrasad
Copy link
Member Author

Ran with: https://github.com/getsentry/sentry-javascript/actions/runs/4915821897/jobs/8778785543, react e2e tests pass, but the nextjs ones are failing.

@AbhiPrasad
Copy link
Member Author

image

Get hyped for canary tests!!

@AbhiPrasad AbhiPrasad merged commit e3ba0ad into develop May 8, 2023
@AbhiPrasad AbhiPrasad deleted the abhi-react-canary branch May 8, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants