Skip to content

chore(node-integration-tests): Improve local testing experience #8714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Aug 2, 2023

This PR adds a few improvements to the node integration tests:

  • Re-add support for -t arg to filter for specific tests
  • Re-add support for --watch flag
  • Reduce logging for test suites where all tests were skipped. This makes running one specific (e.g. new or modified) test a much better experience locally as you don't have to go through 100s lines of unnecessary console output. Happy to even reduce it further to log nothing at all if reviewers prefer that.
  • Add yargs to parse arguments (and provide help)

Came up while modifying a node integration test for #8715 and finding out that running them locally is super annoying 😅

@Lms24 Lms24 requested review from a team, lforst and ale-cota and removed request for a team August 2, 2023 10:51
@Lms24
Copy link
Member Author

Lms24 commented Aug 2, 2023

lol the yargs version I use isn't compatible w/ Node 10... Let's see how far we have to go back 😅

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 74.7 KB (-0.55% 🔽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.11 KB (-0.98% 🔽)
@sentry/browser - Webpack (gzipped) 21.81 KB (-0.69% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 69.52 KB (-0.49% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 28.14 KB (-0.59% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 20.15 KB (-0.96% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 218.93 KB (-0.99% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 84.63 KB (-1.66% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 59.8 KB (-1.23% 🔽)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 30.43 KB (+0.01% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 64.91 KB (-0.41% 🔽)
@sentry/react - Webpack (gzipped) 21.84 KB (-0.63% 🔽)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 92.52 KB (-0.45% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 50.61 KB (-0.54% 🔽)

@Lms24 Lms24 merged commit 7e3f0dc into develop Aug 2, 2023
@Lms24 Lms24 deleted the lms/ref-node-integ-tests-local-testing branch August 2, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants