Skip to content

ref(node): Don't call JSON.stringify on prisma client when logging #8745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

lforst
Copy link
Contributor

@lforst lforst commented Aug 7, 2023

JSON.stringify will throw when called on circular structures. This is an unnecessary risk in the prisma integration so we just log it plainly.

Ref: #8532

`JSON.stringify` will throw when called on circular structures. This is an unnecessary risk in the prisma integration so we just log it plainly.

Ref: #8532
@lforst lforst requested a review from mydea August 7, 2023 12:05
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable!

@lforst lforst merged commit f7d37a0 into develop Aug 7, 2023
@lforst lforst deleted the lforst-dont-json-stringify-prisma-client branch August 7, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants