-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix(jsdoc): tracePropagationTargets
defaults are localhost and same origin
#8749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless I'm totally missing something, this is only the behaviour in Browser, due to the of the CORS issues. For Node, we attach the headers to all outgoing requests.
Can we change/override the JSDoc in browser or node (I'll leave this up to you) so that it reflects the behaviour correctly everywhere?
@Lms24 Thanks, I've added JSDoc to Node, now it should be correct everywhere. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @krystofwoldrich!
The js doc was outdated.