feat(node): Add basic cloud resource context #8764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lforst
commented
Aug 9, 2023
| 'cloud.provider': 'gcp', | ||
| }; | ||
| } else if (process.env.ALIYUN_REGION_ID) { | ||
| // TODO: find where I found these environment variables - at least gc.github.com returns something |
There was a problem hiding this comment.
Note that I haven't figured this out yet. This is not a leftover in this PR but an actual todo.
Lms24
approved these changes
Aug 9, 2023
There was a problem hiding this comment.
LGTM! RE origin of env variables, I think as long as the providers we're most interested in are covered we should be good. As discussed offline, let's add cloudflare but otherwise 
I'm not sure if other SDKs already send this context but if they do we might want to cross-check the env variables.
size-limit report 📦
|
I just tried to find some way of detecting a CF env but I failed. We could do it similar to python where we look at incoming request headers but that's a job for future Luca. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8747
Adds a bit of cloud resource context based on environment variables that may or may not be available in certain cloud environments.
Note that I didn't manually check all of these environment variables but based them off of stuff I've found on the internet. I tried to put links to the places where I found them but for some of them I lost the link. For these instances GitHub codesearch shows a few results though so I kinda trust them.