feat(replay): Allow to configure maxReplayDuration
#8769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
force-pushed
the
fn/add-replay-maxDuration
branch
from
8cc5a7f to
6363e66
Compare
size-limit report 📦
|
billyvg
reviewed
Aug 9, 2023
| @@ -148,7 +147,6 @@ export class ReplayContainer implements ReplayContainerInterface { | |||
| this.timeouts = { | |||
| sessionIdlePause: SESSION_IDLE_PAUSE_DURATION, | |||
| sessionIdleExpire: SESSION_IDLE_EXPIRE_DURATION, | |||
| maxSessionLife: MAX_SESSION_LIFE, | |||
There was a problem hiding this comment.
Why not keep the max duration part of timeouts?
There was a problem hiding this comment.
🤷 just aligning this - the only reason these timeouts exist was to allow overwriting them in tests, which can now be done "correctly"/publicly via maxReplayDuration?
mydea
force-pushed
the
fn/add-replay-maxDuration
branch
from
6363e66 to
ed1ac3b
Compare
|
note: I rebased on develop, fixing inconsistencies. |
mydea
force-pushed
the
fn/add-replay-maxDuration
branch
2 times, most recently
from
cc1a468 to
7f6fbad
Compare
mydea
force-pushed
the
fn/add-replay-maxDuration
branch
from
7f6fbad to
db0d4f6
Compare
billyvg
approved these changes
Aug 30, 2023
This defaults to 60min, and is capped at max. 60min (=you cannot specify a longer max duration than 60min).
mydea
force-pushed
the
fn/add-replay-maxDuration
branch
from
db0d4f6 to
8f62064
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This defaults to 60min, and is capped at max. 60min (=you cannot specify a longer max duration than 60min).
Closes #8758