Skip to content

fix(replay): Resume replay recording if paused when session is expired #8889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Aug 28, 2023

Previously was attempting to take full snapshot when replay recording was not active.

Fixes #8885

Previously was attempting to take full snapshot when replay recording was not active.

Fixes #8885
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 75.22 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.19 KB (-0.05% 🔽)
@sentry/browser - Webpack (gzipped) 21.84 KB (-0.04% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 69.75 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 28.21 KB (-0.02% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 20.18 KB (-0.04% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 220.06 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 84.86 KB (-0.03% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 59.85 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.1 KB (-0.02% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 75.24 KB (0%)
@sentry/react - Webpack (gzipped) 21.87 KB (-0.04% 🔽)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 93.04 KB (+0.01% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 50.73 KB (-0.02% 🔽)

@billyvg billyvg marked this pull request as ready for review August 28, 2023 21:43
@billyvg billyvg requested a review from mydea August 28, 2023 21:43
@billyvg billyvg merged commit aab71b1 into develop Aug 29, 2023
@billyvg billyvg deleted the fix-replay-require-resume-before-takeFullSnapshot branch August 29, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix resuming replay without recording
2 participants