fix(node): Improve mysql integration #8923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Make sure it works consistently when not calling `connection.connect()` - it used to only register the mysql config on the second call, as it calls `connect` under the hood but only after we already tried to fetch it again. 2. Make sure it works without a callback.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| }); | ||
|
|
||
| const connection = mysql.createConnection({ | ||
| user: 'root', |
Check failure
Code scanning / CodeQL
Hard-coded credentials
|
|
||
| const connection = mysql.createConnection({ | ||
| user: 'root', | ||
| password: 'docker', |
Check failure
Code scanning / CodeQL
Hard-coded credentials
| }); | ||
|
|
||
| const connection = mysql.createConnection({ | ||
| user: 'root', |
Check failure
Code scanning / CodeQL
Hard-coded credentials
|
|
||
| const connection = mysql.createConnection({ | ||
| user: 'root', | ||
| password: 'docker', |
Check failure
Code scanning / CodeQL
Hard-coded credentials
AbhiPrasad
approved these changes
Aug 31, 2023
Lms24
approved these changes
Sep 1, 2023
| @@ -14,6 +14,9 @@ test('should auto-instrument `mysql` package.', async () => { | |||
| op: 'db', | |||
| data: { | |||
| 'db.system': 'mysql', | |||
| 'server.address': 'localhost', | |||
| 'server.port': 3306, | |||
| 'db.user': 'root', | |||
There was a problem hiding this comment.
just to sanity-check (becaus afaict assertSentryTransaction doesn't require strict equality): We don't collect something like db.password, rigth? 😅
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connection.connect()(which is optional) - it used to only register the mysql config on the second call, as it callsconnectunder the hood but only after we already tried to fetch it again.