Skip to content

fix(node-experimental): Use Sentry logger as Otel logger #8960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2023
Merged

fix(node-experimental): Use Sentry logger as Otel logger #8960

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions packages/node-experimental/src/sdk/initOtel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import { diag, DiagConsoleLogger, DiagLogLevel } from '@opentelemetry/api';
import { diag, DiagLogLevel } from '@opentelemetry/api';
import { AlwaysOnSampler, NodeTracerProvider } from '@opentelemetry/sdk-trace-node';
import { getCurrentHub } from '@sentry/core';
import { SentryPropagator, SentrySpanProcessor } from '@sentry/opentelemetry-node';
import { logger } from '@sentry/utils';

import type { NodeExperimentalClient } from './client';
import { SentryContextManager } from './otelContextManager';
Expand All @@ -14,7 +15,14 @@ export function initOtel(): () => void {
const client = getCurrentHub().getClient<NodeExperimentalClient>();

if (client?.getOptions().debug) {
diag.setLogger(new DiagConsoleLogger(), DiagLogLevel.DEBUG);
const otelLogger = new Proxy(logger as typeof logger & { verbose: (typeof logger)['debug'] }, {
get(target, prop, receiver) {
const actualProp = prop === 'verbose' ? 'debug' : prop;
return Reflect.get(target, actualProp, receiver);
},
});

diag.setLogger(otelLogger, DiagLogLevel.DEBUG);
}

// Create and configure NodeTracerProvider
Expand Down