Skip to content

feat(utils): Add parameterize function #9145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from 27 commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
db66295
Added parametrize function
AleshaOleg Sep 29, 2023
e15d5f1
Populate logentry parameter if it's exist for eventFromMessage functions
AleshaOleg Oct 11, 2023
7b27a1e
Merge branch 'develop' of github.com:getsentry/sentry-javascript into…
AleshaOleg Oct 11, 2023
e4c4d4c
Renamed parametrize to parameterize and moved ParameterizedString typ…
AleshaOleg Oct 13, 2023
8fa0552
Added integration tests
AleshaOleg Oct 13, 2023
d83411a
Fixing tests and improvements
AleshaOleg Oct 13, 2023
70e6864
isParameterized -> isParameterizedString in docs
AleshaOleg Oct 13, 2023
cbd0805
Fixed lint errors
AleshaOleg Oct 14, 2023
1020b14
Minor optimization
AleshaOleg Oct 14, 2023
99c4fbb
Merge branch 'develop' of github.com:getsentry/sentry-javascript into…
AleshaOleg Oct 14, 2023
3cbe665
Minor improvements, reverted prisma update
AleshaOleg Oct 16, 2023
de6e723
Fixed typo
AleshaOleg Oct 16, 2023
28758b6
Fixed typo
AleshaOleg Oct 16, 2023
17a4bbd
Merge branch 'develop' of github.com:getsentry/sentry-javascript into…
AleshaOleg Oct 16, 2023
2c3393f
[email protected] -> prisma@^3.12.0
AleshaOleg Oct 16, 2023
f6347a3
Merge branch 'develop' of github.com:getsentry/sentry-javascript into…
AleshaOleg Oct 16, 2023
cefa81c
prisma@^3.12.0 -> [email protected]
AleshaOleg Oct 17, 2023
e80f23a
[email protected] -> prisma@^3.12.0
AleshaOleg Oct 17, 2023
3b67901
Merge branch 'develop' of github.com:getsentry/sentry-javascript into…
AleshaOleg Oct 17, 2023
2789d04
[email protected] -> prisma@^3.12.0
AleshaOleg Oct 17, 2023
3e3b441
Merge branch 'develop' of github.com:AleshaOleg/sentry-javascript int…
AleshaOleg Nov 30, 2023
0d67997
Fixed Biome errors
AleshaOleg Dec 1, 2023
dcd1549
Merge branch 'develop' of https://github.com/getsentry/sentry-javascr…
AleshaOleg Dec 21, 2023
ca8a58a
Merge branch 'develop' of https://github.com/getsentry/sentry-javascr…
AleshaOleg Dec 30, 2023
8c8bf10
Skipping test for some bundles
AleshaOleg Dec 31, 2023
a631c55
Prevent running test for tracing builds
AleshaOleg Jan 2, 2024
aa3c9d1
Merge branch 'develop' of https://github.com/getsentry/sentry-javascr…
AleshaOleg Jan 2, 2024
de11d01
Skipping all test for bundle builds
AleshaOleg Jan 4, 2024
5aeedf7
Merge branch 'develop' of https://github.com/getsentry/sentry-javascr…
AleshaOleg Jan 4, 2024
f68be1f
Test migration to dev-packages folder
AleshaOleg Jan 4, 2024
5681add
Merge branch 'develop' of https://github.com/getsentry/sentry-javascr…
AleshaOleg Jan 4, 2024
4b0c53c
Merge branch 'develop' into feature/added-parametrize-function
AleshaOleg Jan 5, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import { parameterize } from '@sentry/utils';

const x = 'first';
const y = 'second';

Sentry.captureMessage(parameterize`This is a log statement with ${x} and ${y} params`);
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
import { expect } from '@playwright/test';
import type { Event } from '@sentry/types';

import { sentryTest } from '../../../../utils/fixtures';
import { getFirstSentryEnvelopeRequest, shouldSkipTracingTest } from '../../../../utils/helpers';
import { shouldSkipReplayTest } from '../../../../utils/replayHelpers';

sentryTest('should capture a parameterized representation of the message', async ({ getLocalTestPath, page }) => {
if (shouldSkipReplayTest() || !shouldSkipTracingTest()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not gonna be enough. We need to skip all bundle_ variants for now. These two functions won't do that.

basically like in this test:

const bundle = process.env.PW_BUNDLE;
if (!bundle || !bundle.startsWith('bundle_') || bundle.includes('replay')) {
sentryTest.skip();
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the hint about skipping the test for all bundle builds.
I made changes, should work now.

Can you also explain how you are testing such functions for public API for CDN bundles? Because importing functions directly to tests will not work, and I'm wondering how I can test them. Just an example would be enough, I didn't find anything similar in browser-integration-tests. Will do it as a separate PR as you mentioned

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So as soon as we export parameterize from @sentry/browser, our CDN bundles will also include it as a top level function to call on the Sentry object. Meaning, CDN bundle users can call

Sentry.captureMessage(Sentry.parameterize`This is a log statement with ${x} and ${y} params`);

we can adjust the integration tests to do that and stop importing it from @sentry/utils.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's generally how we test public API in the browser integration tests, across NPM package (esm, cjs) and CDN bundle variants.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a simple example, take a look at this test: https://github.com/getsentry/sentry-javascript/blob/23ef22b115c8868861896cc9003bd4bb6afb0690/dev-packages/browser-integration-tests/suites/public-api/setTag/with_primitives/subject.js

calling Sentry.parameterize should work just like calling Sentry.setTag once we export it from the browser package.

Copy link
Contributor Author

@AleshaOleg AleshaOleg Jan 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just tried also throws timeouts locally, but works with esm, cjs builds. Will do separate PR for that, and will mention you to run tests there, let's see if it will work on cloud setup. A lot of other tests also failing for me locally because of timeout for example for bundle_tracing_replay_es6_min, so I'm not quite sure if it works or not.

For now please merge it, just pulled latest changes from develop and I'll do separate PR for running tests for all of the builds and make this function available from browser API. Thanks!

sentryTest.skip();
}

const url = await getLocalTestPath({ testDir: __dirname });

const eventData = await getFirstSentryEnvelopeRequest<Event>(page, url);

expect(eventData.logentry).toStrictEqual({
message: 'This is a log statement with %s and %s params',
params: ['first', 'second'],
});
});
3 changes: 2 additions & 1 deletion packages/browser/src/client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import type {
Event,
EventHint,
Options,
ParameterizedString,
Severity,
SeverityLevel,
UserFeedback,
Expand Down Expand Up @@ -84,7 +85,7 @@ export class BrowserClient extends BaseClient<BrowserClientOptions> {
* @inheritDoc
*/
public eventFromMessage(
message: string,
message: ParameterizedString,
// eslint-disable-next-line deprecation/deprecation
level: Severity | SeverityLevel = 'info',
hint?: EventHint,
Expand Down
33 changes: 26 additions & 7 deletions packages/browser/src/eventbuilder.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
import { getClient } from '@sentry/core';
import type { Event, EventHint, Exception, Severity, SeverityLevel, StackFrame, StackParser } from '@sentry/types';
import type {
Event,
EventHint,
Exception,
ParameterizedString,
Severity,
SeverityLevel,
StackFrame,
StackParser,
} from '@sentry/types';
import {
addExceptionMechanism,
addExceptionTypeValue,
Expand All @@ -9,6 +18,7 @@ import {
isError,
isErrorEvent,
isEvent,
isParameterizedString,
isPlainObject,
normalizeToSize,
resolvedSyncPromise,
Expand Down Expand Up @@ -167,7 +177,7 @@ export function eventFromException(
*/
export function eventFromMessage(
stackParser: StackParser,
message: string,
message: ParameterizedString,
// eslint-disable-next-line deprecation/deprecation
level: Severity | SeverityLevel = 'info',
hint?: EventHint,
Expand Down Expand Up @@ -264,23 +274,32 @@ export function eventFromUnknownInput(
*/
export function eventFromString(
stackParser: StackParser,
input: string,
message: ParameterizedString,
syntheticException?: Error,
attachStacktrace?: boolean,
): Event {
const event: Event = {
message: input,
};
const event: Event = {};

if (attachStacktrace && syntheticException) {
const frames = parseStackFrames(stackParser, syntheticException);
if (frames.length) {
event.exception = {
values: [{ value: input, stacktrace: { frames } }],
values: [{ value: message, stacktrace: { frames } }],
};
}
}

if (isParameterizedString(message)) {
const { __sentry_template_string__, __sentry_template_values__ } = message;

event.logentry = {
message: __sentry_template_string__,
params: __sentry_template_values__,
};
return event;
}

event.message = message;
return event;
}

Expand Down
10 changes: 7 additions & 3 deletions packages/core/src/baseclient.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import type {
MetricBucketItem,
MetricsAggregator,
Outcome,
ParameterizedString,
PropagationContext,
SdkMetadata,
Session,
Expand All @@ -36,6 +37,7 @@ import {
addItemToEnvelope,
checkOrSetAlreadyCaught,
createAttachmentEnvelopeItem,
isParameterizedString,
isPlainObject,
isPrimitive,
isThenable,
Expand Down Expand Up @@ -182,16 +184,18 @@ export abstract class BaseClient<O extends ClientOptions> implements Client<O> {
* @inheritDoc
*/
public captureMessage(
message: string,
message: ParameterizedString,
// eslint-disable-next-line deprecation/deprecation
level?: Severity | SeverityLevel,
hint?: EventHint,
scope?: Scope,
): string | undefined {
let eventId: string | undefined = hint && hint.event_id;

const eventMessage = isParameterizedString(message) ? message : String(message);

const promisedEvent = isPrimitive(message)
? this.eventFromMessage(String(message), level, hint)
? this.eventFromMessage(eventMessage, level, hint)
: this.eventFromException(message, hint);

this._process(
Expand Down Expand Up @@ -816,7 +820,7 @@ export abstract class BaseClient<O extends ClientOptions> implements Client<O> {
* @inheritDoc
*/
public abstract eventFromMessage(
_message: string,
_message: ParameterizedString,
// eslint-disable-next-line deprecation/deprecation
_level?: Severity | SeverityLevel,
_hint?: EventHint,
Expand Down
3 changes: 2 additions & 1 deletion packages/core/src/server-runtime-client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import type {
Event,
EventHint,
MonitorConfig,
ParameterizedString,
SerializedCheckIn,
Severity,
SeverityLevel,
Expand Down Expand Up @@ -62,7 +63,7 @@ export class ServerRuntimeClient<
* @inheritDoc
*/
public eventFromMessage(
message: string,
message: ParameterizedString,
// eslint-disable-next-line deprecation/deprecation
level: Severity | SeverityLevel = 'info',
hint?: EventHint,
Expand Down
3 changes: 2 additions & 1 deletion packages/core/test/mocks/client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import type {
EventHint,
Integration,
Outcome,
ParameterizedString,
Session,
Severity,
SeverityLevel,
Expand Down Expand Up @@ -76,7 +77,7 @@ export class TestClient extends BaseClient<TestClientOptions> {
}

public eventFromMessage(
message: string,
message: ParameterizedString,
// eslint-disable-next-line deprecation/deprecation
level: Severity | SeverityLevel = 'info',
): PromiseLike<Event> {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import * as Sentry from '@sentry/node';
import { parameterize } from '@sentry/utils';

Sentry.init({
dsn: 'https://[email protected]/1337',
release: '1.0',
});

const x = 'first';
const y = 'second';

Sentry.captureMessage(parameterize`This is a log statement with ${x} and ${y} params`);
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
import { TestEnv, assertSentryEvent } from '../../../../utils';

test('should capture a parameterized representation of the message', async () => {
const env = await TestEnv.init(__dirname);
const event = await env.getEnvelopeRequest();

assertSentryEvent(event[2], {
logentry: {
message: 'This is a log statement with %s and %s params',
params: ['first', 'second'],
},
});
});
10 changes: 8 additions & 2 deletions packages/replay/test/utils/TestClient.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
import { BaseClient, createTransport, initAndBind } from '@sentry/core';
import type { BrowserClientReplayOptions, ClientOptions, Event, SeverityLevel } from '@sentry/types';
import type {
BrowserClientReplayOptions,
ClientOptions,
Event,
ParameterizedString,
SeverityLevel,
} from '@sentry/types';
import { resolvedSyncPromise } from '@sentry/utils';

export interface TestClientOptions extends ClientOptions, BrowserClientReplayOptions {}
Expand All @@ -24,7 +30,7 @@ export class TestClient extends BaseClient<TestClientOptions> {
});
}

public eventFromMessage(message: string, level: SeverityLevel = 'info'): PromiseLike<Event> {
public eventFromMessage(message: ParameterizedString, level: SeverityLevel = 'info'): PromiseLike<Event> {
return resolvedSyncPromise({ message, level });
}
}
Expand Down
10 changes: 8 additions & 2 deletions packages/tracing-internal/test/utils/TestClient.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
import { BaseClient, createTransport, initAndBind } from '@sentry/core';
import type { BrowserClientReplayOptions, ClientOptions, Event, SeverityLevel } from '@sentry/types';
import type {
BrowserClientReplayOptions,
ClientOptions,
Event,
ParameterizedString,
SeverityLevel,
} from '@sentry/types';
import { resolvedSyncPromise } from '@sentry/utils';

export interface TestClientOptions extends ClientOptions, BrowserClientReplayOptions {}
Expand All @@ -24,7 +30,7 @@ export class TestClient extends BaseClient<TestClientOptions> {
});
}

public eventFromMessage(message: string, level: SeverityLevel = 'info'): PromiseLike<Event> {
public eventFromMessage(message: ParameterizedString, level: SeverityLevel = 'info'): PromiseLike<Event> {
return resolvedSyncPromise({ message, level });
}
}
Expand Down
3 changes: 2 additions & 1 deletion packages/types/src/client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import type { FeedbackEvent } from './feedback';
import type { Integration, IntegrationClass } from './integration';
import type { MetricBucketItem } from './metrics';
import type { ClientOptions } from './options';
import type { ParameterizedString } from './parameterize';
import type { Scope } from './scope';
import type { SdkMetadata } from './sdkmetadata';
import type { Session, SessionAggregates } from './session';
Expand Down Expand Up @@ -159,7 +160,7 @@ export interface Client<O extends ClientOptions = ClientOptions> {

/** Creates an {@link Event} from primitive inputs to `captureMessage`. */
eventFromMessage(
message: string,
message: ParameterizedString,
// eslint-disable-next-line deprecation/deprecation
level?: Severity | SeverityLevel,
hint?: EventHint,
Expand Down
4 changes: 4 additions & 0 deletions packages/types/src/event.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ import type { User } from './user';
export interface Event {
event_id?: string;
message?: string;
logentry?: {
message?: string;
params?: string[];
};
timestamp?: number;
start_timestamp?: number;
// eslint-disable-next-line deprecation/deprecation
Expand Down
1 change: 1 addition & 0 deletions packages/types/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -140,3 +140,4 @@ export type {
export type { BrowserClientReplayOptions, BrowserClientProfilingOptions } from './browseroptions';
export type { CheckIn, MonitorConfig, FinishedCheckIn, InProgressCheckIn, SerializedCheckIn } from './checkin';
export type { MetricsAggregator, MetricBucketItem, MetricInstance } from './metrics';
export type { ParameterizedString } from './parameterize';
4 changes: 4 additions & 0 deletions packages/types/src/parameterize.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
export type ParameterizedString = string & {
__sentry_template_string__?: string;
__sentry_template_values__?: string[];
};
17 changes: 14 additions & 3 deletions packages/utils/src/eventbuilder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,14 @@ import type {
Extras,
Hub,
Mechanism,
ParameterizedString,
Severity,
SeverityLevel,
StackFrame,
StackParser,
} from '@sentry/types';

import { isError, isPlainObject } from './is';
import { isError, isParameterizedString, isPlainObject } from './is';
import { addExceptionMechanism, addExceptionTypeValue } from './misc';
import { normalizeToSize } from './normalize';
import { extractExceptionKeysForMessage } from './object';
Expand Down Expand Up @@ -127,7 +128,7 @@ export function eventFromUnknownInput(
*/
export function eventFromMessage(
stackParser: StackParser,
message: string,
message: ParameterizedString,
// eslint-disable-next-line deprecation/deprecation
level: Severity | SeverityLevel = 'info',
hint?: EventHint,
Expand All @@ -136,7 +137,6 @@ export function eventFromMessage(
const event: Event = {
event_id: hint && hint.event_id,
level,
message,
};

if (attachStacktrace && hint && hint.syntheticException) {
Expand All @@ -153,5 +153,16 @@ export function eventFromMessage(
}
}

if (isParameterizedString(message)) {
const { __sentry_template_string__, __sentry_template_values__ } = message;

event.logentry = {
message: __sentry_template_string__,
params: __sentry_template_values__,
};
return event;
}

event.message = message;
return event;
}
1 change: 1 addition & 0 deletions packages/utils/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ export * from './url';
export * from './userIntegrations';
export * from './cache';
export * from './eventbuilder';
export * from './parameterize';
export * from './anr';
export * from './lru';
export * from './buildPolyfills';
Loading