Skip to content

test(loader): Improve loader tests & update loader #9245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 19, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Oct 13, 2023

This updates the loader based on this PR: getsentry/sentry#58070
and also actually fixes/improves the loader tests by avoiding importing @sentry/browser. This is not needed and actually obfuscates the "real"/"normal" behavior (just look at the generated dist folder for a test.

Instead, I added an eslint rule to allow Sentry as a global for these cases, and just access them directly. This also uncovered an incorrect test, which I adjusted so it works. I also added a new test to ensure custom config works.

@mydea mydea requested review from lforst, Lms24 and AbhiPrasad October 13, 2023 12:11
@mydea mydea self-assigned this Oct 13, 2023
@mydea mydea force-pushed the fn/repro-loader-issue branch 2 times, most recently from 09c5fad to b3d5482 Compare October 18, 2023 14:30
@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2023

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 84 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.6 KB (0%)
@sentry/browser - Webpack (gzipped) 21.77 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 80.5 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 29.54 KB (-0.01% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 21.71 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 245.65 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 85.63 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 61.55 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 32.66 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 84.07 KB (0%)
@sentry/react - Webpack (gzipped) 21.81 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 102.21 KB (0%)
@sentry/nextjs Client - Webpack (gzipped) 49.67 KB (0%)

@mydea mydea force-pushed the fn/repro-loader-issue branch from b3d5482 to 4a04a2f Compare October 19, 2023 07:20
@mydea mydea merged commit 8d5c306 into develop Oct 19, 2023
@mydea mydea deleted the fn/repro-loader-issue branch October 19, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants