Skip to content

chore: Fix typos #9315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ Additional labels for categorization can be added, and the Sentry SDK team may a
### Pull Requests (PRs)

PRs are merged via `Squash and merge`.
This means that all commits on the branch will be squashed into a single commit, and commited as such onto master.
This means that all commits on the branch will be squashed into a single commit, and committed as such onto master.

* The PR name can generally follow the commit name (e.g. `feat(core): Set custom transaction source for event processors`)
* Make sure to rebase the branch on `master` before squashing it
Expand Down
8 changes: 4 additions & 4 deletions MIGRATION.md
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ Sentry.init({

## Replay options changed (since 7.35.0) - #6645

Some options for replay have been depracted in favor of new APIs.
Some options for replay have been deprecated in favor of new APIs.
See [Replay Migration docs](./packages/replay/MIGRATION.md#upgrading-replay-from-7340-to-7350) for details.

## Renaming of Next.js wrapper methods (since 7.31.0) - #6790
Expand Down Expand Up @@ -162,7 +162,7 @@ Running the new SDK version on Node.js v6 is therefore highly discouraged.

## Removal of `@sentry/minimal`

The `@sentry/minimal` package was deleted and it's functionality was moved to `@sentry/hub`. All exports from `@sentry/minimal` should be avaliable in `@sentry/hub` other than `_callOnClient` function which was removed.
The `@sentry/minimal` package was deleted and it's functionality was moved to `@sentry/hub`. All exports from `@sentry/minimal` should be available in `@sentry/hub` other than `_callOnClient` function which was removed.

```ts
// New in v7:
Expand All @@ -184,7 +184,7 @@ import {

## Explicit Client Options

In v7, we've updated the `Client` to have options seperate from the options passed into `Sentry.init`. This means that constructing a client now requires 3 options: `integrations`, `transport` and `stackParser`. These can be customized as you see fit.
In v7, we've updated the `Client` to have options separate from the options passed into `Sentry.init`. This means that constructing a client now requires 3 options: `integrations`, `transport` and `stackParser`. These can be customized as you see fit.

```ts
import { BrowserClient, defaultStackParser, defaultIntegrations, makeFetchTransport } from '@sentry/browser';
Expand Down Expand Up @@ -764,7 +764,7 @@ this case is the `event_id`, in case the event will not be sent because of filte
In `4.x` we had both `close` and `flush` on the `Client` draining the internal queue of events, helpful when you were
using `@sentry/node` on a serverless infrastructure.

Now `close` and `flush` work similar, with the difference that if you call `close` in addition to returing a `Promise`
Now `close` and `flush` work similar, with the difference that if you call `close` in addition to returning a `Promise`
that you can await it also **disables** the client so it will not send any future events.

# Migrating from `raven-js` to `@sentry/browser`
Expand Down