Skip to content

fix(node): Improve error handling and shutdown handling for ANR #9548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2023
Merged

fix(node): Improve error handling and shutdown handling for ANR #9548

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions packages/node/src/anr/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,15 +215,21 @@ function handleChildProcess(options: Options): void {

async function watchdogTimeout(): Promise<void> {
log('Watchdog timeout');
const pauseAndCapture = await debuggerPause;

if (pauseAndCapture) {
log('Pausing debugger to capture stack trace');
pauseAndCapture();
} else {
log('Capturing event');
sendAnrEvent();

try {
const pauseAndCapture = await debuggerPause;

if (pauseAndCapture) {
log('Pausing debugger to capture stack trace');
pauseAndCapture();
return;
}
} catch (_) {
// ignore
}

log('Capturing event');
sendAnrEvent();
}

const { poll } = watchdogTimer(createHrTimer, options.pollInterval, options.anrThreshold, watchdogTimeout);
Expand All @@ -234,6 +240,10 @@ function handleChildProcess(options: Options): void {
}
poll();
});
process.on('disconnect', () => {
// Parent process has exited.
process.exit();
});
}

/**
Expand Down