Skip to content

ref(feedback): Remove isAnonymous option from feedback #9602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

c298lee
Copy link
Contributor

@c298lee c298lee commented Nov 20, 2023

Remove isAnonymous option from feedback because it clashes with sentry user

Closes #9585

@c298lee c298lee requested a review from a team November 20, 2023 19:44
Copy link
Contributor

github-actions bot commented Nov 20, 2023

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 65.53 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 55.67 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.01 KB (0%)
@sentry/browser - Webpack (gzipped) 21.32 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 61.99 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 29.13 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 21.26 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 195.53 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 88.38 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 63.34 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.85 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 65.84 KB (0%)
@sentry/react - Webpack (gzipped) 21.36 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 82.58 KB (0%)
@sentry/nextjs Client - Webpack (gzipped) 48.15 KB (0%)
@sentry-internal/feedback - Webpack (gzipped) 16.16 KB (-0.29% 🔽)

Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does README need to be updated?

@c298lee
Copy link
Contributor Author

c298lee commented Nov 20, 2023

Does README need to be updated?

updating it now for isAnonymous, isNameRequired and isEmailRequired

@c298lee c298lee requested a review from billyvg November 20, 2023 20:11
@c298lee c298lee merged commit dbce251 into develop Nov 20, 2023
@c298lee c298lee deleted the remove-isanonymous branch November 20, 2023 20:27
@AbhiPrasad
Copy link
Member

I think we're going to enforce squashing commits but we need to make sure that gitflow works properly with it first. In the time being @c298lee mind making sure you squash and merge your commits when merging PRs? We need to fix giving the option, but just in the short term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

isAnonymous should also remove the user context from the feedback event
3 participants