Skip to content

chore: Remove scenarios #9667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 27, 2023
Merged

chore: Remove scenarios #9667

merged 2 commits into from
Nov 27, 2023

Conversation

AbhiPrasad
Copy link
Member

This is code that isn't being used anywhere, and the code snippets are out of date (look at custom transport code).

We can explore adding this back for v8.

@AbhiPrasad AbhiPrasad requested review from a team, lforst and Lms24 and removed request for a team November 27, 2023 16:30
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! I wouldn't invest much time into bringing them back. Our integration tests partly sport very similar scenario and have to be kept up to date anyway.

Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 65.86 KB (-0.24% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 59.46 KB (+5.79% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.11 KB (-0.26% 🔽)
@sentry/browser - Webpack (gzipped) 21.38 KB (-0.12% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 62.71 KB (+0.11% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 29.52 KB (+0.19% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 21.6 KB (+0.2% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 197.46 KB (+0.1% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 89.32 KB (+0.2% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 64.29 KB (+0.27% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 32.21 KB (+0.29% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 66.24 KB (-0.28% 🔽)
@sentry/react - Webpack (gzipped) 21.42 KB (-0.12% 🔽)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 82.96 KB (-0.25% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 48.21 KB (-0.23% 🔽)
@sentry-internal/feedback - Webpack (gzipped) 16.19 KB (-0.02% 🔽)

@AbhiPrasad AbhiPrasad merged commit 0c8aee3 into develop Nov 27, 2023
@AbhiPrasad AbhiPrasad deleted the abhi-remove-scenarios branch November 27, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants