Skip to content

ref(serverless): Avoid using pushScope #9883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 18, 2023
Merged

ref(serverless): Avoid using pushScope #9883

merged 2 commits into from
Dec 18, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Dec 18, 2023

This is the only place I've found where we use pushScope, and since we updated the withScope signature we can rewrite this.

@mydea mydea requested review from lforst and Lms24 December 18, 2023 09:21
@mydea mydea self-assigned this Dec 18, 2023
@mydea mydea force-pushed the fn/avoid-pushScope branch from 76af2e3 to bc27c80 Compare December 18, 2023 10:37
Copy link
Contributor

github-actions bot commented Dec 18, 2023

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 75.16 KB (-0.04% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 66.58 KB (-0.05% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 60.18 KB (-0.06% 🔽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.26 KB (-0.06% 🔽)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 29.87 KB (-0.04% 🔽)
@sentry/browser - Webpack (gzipped) 21.56 KB (-0.04% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 72.6 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 64.31 KB (-0.05% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 30.57 KB (-0.05% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 22.63 KB (-0.08% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 202.28 KB (-0.07% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 92.4 KB (-0.15% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 67.45 KB (-0.2% 🔽)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 33.47 KB (-0.06% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 66.94 KB (-0.05% 🔽)
@sentry/react - Webpack (gzipped) 21.6 KB (-0.04% 🔽)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 83.72 KB (-0.05% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 48.41 KB (-0.04% 🔽)
@sentry-internal/feedback - Webpack (gzipped) 16.18 KB (0%)

This will be deprecated soon. Instead, use `withScope`.
@mydea mydea force-pushed the fn/avoid-pushScope branch from bc27c80 to e0b310a Compare December 18, 2023 11:21
@mydea mydea merged commit e1d3633 into develop Dec 18, 2023
@mydea mydea deleted the fn/avoid-pushScope branch December 18, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants