ref(browser): Refactor browser integrations to avoid setupOnce
#9898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
approved these changes
Dec 18, 2023
| @@ -29,6 +30,7 @@ export class BrowserProfilingIntegration implements Integration { | |||
|
|
|||
| public readonly name: string; | |||
|
|
|||
| /** @deprecated This is never set. */ | |||
| public getCurrentHub?: () => Hub; | |||
There was a problem hiding this comment.
I think we can just remove this tbh, nobody should be relying on it.
There was a problem hiding this comment.
yeah, I'll remove it in a next step where I rewrite this to functional style!
Also a small core refactor...
mydea
force-pushed
the
fn/browser-setuponce
branch
from
624c9d9 to
1a097a1
Compare
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also a small core refactor...