fix(sveltekit): Avoid capturing 404 errors on client side #9902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
changed the base branch from
develop
to
lms/ref-sveltekit-improve-server-handleError
Closed
AbhiPrasad
approved these changes
Dec 18, 2023
AbhiPrasad
reviewed
Dec 18, 2023
| }); | ||
| return (input: SafeHandleServerErrorInput): ReturnType<HandleClientError> => { | ||
| const { status, message } = input; | ||
| const isNotFoundError = status === 404 && message === 'Not Found'; |
There was a problem hiding this comment.
l: might make sense to extract this into function to use between client/server in case this logic needs to change in the future.
There was a problem hiding this comment.
Would have agreed but now that I simplified the check here and in #9901, I think it's no longer worth to extract checking for a 404 status.
Lms24
force-pushed
the
lms/ref-sveltekit-improve-server-handleError
branch
from
a4e6a66 to
51788bc
Compare
Lms24
force-pushed
the
lms/fix-sveltekit-filter-client-not-found
branch
from
212846c to
b3e504a
Compare
Base automatically changed from
lms/ref-sveltekit-improve-server-handleError
to
develop
December 19, 2023 12:35
Lms24
force-pushed
the
lms/fix-sveltekit-filter-client-not-found
branch
from
b3e504a to
8e8fc17
Compare
Lms24
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I belive, these errors weren't passed to the client side
handleErrorhook in Kit 1.x but in 2.x they're now passed into the hook. This means, we need to filter them out.Added the same logic for the client side as in #9901
ref #9851