ref(integrations): Rewrite pluggable integrations to use functional style #9936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
force-pushed
the
fn/integrations-functional
branch
3 times, most recently
from
2b34740 to
b95347b
Compare
size-limit report 📦
|
AbhiPrasad
approved these changes
Dec 21, 2023
| return { | ||
| name: INTEGRATION_NAME, | ||
| setup(client) { | ||
| if (!client.on) { |
There was a problem hiding this comment.
l: let's add todo v8 comment to remove this?
There was a problem hiding this comment.
We have a whole bunch of these checks already anyhow, I think we'll do a general search for this when we do v8 😅
mydea
force-pushed
the
fn/integrations-functional
branch
from
ff9d07b to
0e1adee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slowly getting there...