Skip to content

test(e2e): Add tests to SvelteKit 2.x E2E test app #9944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 31, 2024

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Dec 20, 2023

This PR adds proper e2e tests to our Sveltekit 2.x test application.

Specifically we now test:

  1. Distributed pageload trace - important for browserTracing rework
  2. Distributed navigation trace - important for browserTracing rework
  3. Client side component error
  4. Client side universal load error
  5. Server side universal load error
  6. Server side server load error
  7. Server route/API error

Decided to revisit this PR to have a good base for the sveltekit part of #10387. Also #9943 is now finally ready for review

@Lms24 Lms24 changed the title test(e2e): Add tests to SvelteKit 2.x test application test(e2e): Add tests to SvelteKit 2.x E2E test app Dec 20, 2023
@Lms24 Lms24 force-pushed the lms/test-sveltekit-2-add-e2e-test-cases branch 2 times, most recently from ed7c0cd to 9edaded Compare December 21, 2023 10:04
@Lms24 Lms24 force-pushed the lms/test-sveltekit-2-add-e2e-test-cases branch from 9edaded to 8d436c8 Compare January 31, 2024 14:39
@Lms24 Lms24 marked this pull request as ready for review January 31, 2024 14:54
@Lms24 Lms24 requested review from mydea and AbhiPrasad January 31, 2024 14:55
@Lms24 Lms24 merged commit f5ffacf into develop Jan 31, 2024
@Lms24 Lms24 deleted the lms/test-sveltekit-2-add-e2e-test-cases branch January 31, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants