Skip to content

Switch from Travis CI to GitHub Actions #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 30, 2021

Conversation

ste93cry
Copy link
Contributor

I just realized we never switched this repository from Travis CI to GitHub Actions: let's do it now!

Copy link
Contributor

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok it seems fine but it's unable to install Symfony 6 since it's unstable for now. Can we change the value so it works anyway? Maybe with something like 6.* || 6.0.x-dev?

@ste93cry
Copy link
Contributor Author

This will not solve the issue, we are still missing the support for Symfony 6.x packages in the core SDK repo 😉

@Jean85
Copy link
Contributor

Jean85 commented Oct 22, 2021

Right! So do you want to merge this anyway? What about the base SDK?

@ste93cry
Copy link
Contributor Author

ste93cry commented Oct 22, 2021

Nah, let's wait until the core SDK is declared compatible with Symfony 6. There is no need to rush the merge here

@ste93cry ste93cry force-pushed the switch-from-travis-ci-to-github-actions branch from 678dc76 to bc1e6d9 Compare November 29, 2021 17:57
@ste93cry ste93cry requested a review from Jean85 November 29, 2021 17:58
@ste93cry ste93cry merged commit 2de7de3 into master Nov 30, 2021
@ste93cry ste93cry deleted the switch-from-travis-ci-to-github-actions branch November 30, 2021 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants