Skip to content

Add default context param #2015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

westonkl
Copy link

No description provided.

@antonpirker
Copy link
Member

Hey @westonkl !

Thanks for the contribution. Could you add a short "why this shoudl be done" explaination in the PR description?

@westonkl
Copy link
Author

Hey @westonkl !

Thanks for the contribution. Could you add a short "why this shoudl be done" explaination in the PR description?

Yes, sorry I was having trouble with testing and local setup so I didn't set it as ready for review. This is the error with make test. I also tried running pytest myself and also errored with my local install.
ERROR: py3.9: unresolvable substitution(s): 'TESTPATH'. Environment variables are missing or defined recursively.

I was responding to #1993

@github-actions
Copy link

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@szokeasaurusrex
Copy link
Member

#2267 fixes the same issue while remaining backwards-compatible with Python 3.10 and below, so we are closing this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants